test(ui): Return router props from initializeOrg#49372
Merged
Conversation
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
priscilawebdev
approved these changes
Jun 16, 2023
Member
priscilawebdev
left a comment
There was a problem hiding this comment.
left a few comments but it looks good to me. It was so verbose before and now it is much better! Thanks for doing that 🚀
| * ``` | ||
| */ | ||
| const routerProps: RouteComponentProps<RouterParams, {}> = { | ||
| params: router.params as any, |
Member
There was a problem hiding this comment.
Suggested change
| params: router.params as any, | |
| params: router.params as Record<string, any>, |
🤷♀️
Member
Author
There was a problem hiding this comment.
it just gets overridden above with RouteComponentProps<RouterParams, {}>
Co-authored-by: Priscila Oliveira <priscila.oliveira@sentry.io>
Contributor
|
PR reverted: 713e372 |
getsentry-bot
added a commit
that referenced
this pull request
Jun 16, 2023
This reverts commit 1933148. Co-authored-by: scttcper <1400464+scttcper@users.noreply.github.com>
scttcper
added a commit
that referenced
this pull request
Jun 16, 2023
)"" This reverts commit 713e372.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps with the conversion of view tests to typescript.
Adds a generic that can correctly type view query parameters.
before
after