ref(hc): Delete get_region_by_id#49435
Merged
Merged
Conversation
Rename Region.id field and expand docstring to explain that all lookups should by done by name instead.
github-actions
Bot
added
the
Scope: Backend
Contributor
Author
|
Just something that I noticed in passing, and saw an opportunity for forestall an antipattern. @leeandher If you've been spinning up live silos in your dev environment and passing the config as JSON, the JSON might need to be updated for the |
leeandher
approved these changes
May 18, 2023
leeandher
left a comment
leeandher
left a comment
Member
There was a problem hiding this comment.
Makes sense, I think some of the outbox code also points at regions by name as well, so making this standard is 👍
dashed
approved these changes
May 19, 2023
Contributor
Author
|
https://github.com/getsentry/getsentry/pull/10616 should be merged before this one (and should resolve "getsentry / backend" CI failures). |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49435 +/- ##
==========================================
+ Coverage 80.94% 80.95% +0.01%
==========================================
Files 4820 4820
Lines 202238 202199 -39
Branches 11364 11364
==========================================
- Hits 163695 163690 -5
+ Misses 38289 38255 -34
Partials 254 254
|
Test with a bogus name rather than a bogus ID number, because RegionSiloClient.__init__ now looks up by name.
volokluev
pushed a commit
that referenced
this pull request
May 30, 2023
Rename Region.id field and expand docstring to explain that all lookups should by done by name instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename Region.id field and expand docstring to explain that all lookups should by done by name instead.