Skip to content

Small ingest_consumer refactor#50135

Merged
Swatinem merged 2 commits into
masterfrom
swatinem/ref-ingest
Jun 1, 2023
Merged

Small ingest_consumer refactor#50135
Swatinem merged 2 commits into
masterfrom
swatinem/ref-ingest

Conversation

@Swatinem

@Swatinem Swatinem commented Jun 1, 2023

Copy link
Copy Markdown
Contributor
  • Move process_event code around so its easier to read
  • Resolve projects outside of process_X functions
  • Add a few types that were missing

- Move `process_event` code around so its easier to read
- Resolve projects outside of `process_X` functions
- Add a few types that were missing
@Swatinem Swatinem requested review from a team and jan-auer June 1, 2023 08:27
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 1, 2023

@jan-auer jan-auer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Swatinem Swatinem enabled auto-merge (squash) June 1, 2023 08:41
@codecov

codecov Bot commented Jun 1, 2023

Copy link
Copy Markdown

Codecov Report

Merging #50135 (e73f3a2) into master (bbe4001) will decrease coverage by 0.02%.
The diff coverage is 80.76%.

❗ Current head e73f3a2 differs from pull request most recent head ebd2416. Consider uploading reports for the commit ebd2416 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #50135      +/-   ##
==========================================
- Coverage   81.09%   81.07%   -0.02%     
==========================================
  Files        4841     4841              
  Lines      203031   203018      -13     
  Branches    11272    11272              
==========================================
- Hits       164639   164594      -45     
- Misses      38143    38175      +32     
  Partials      249      249              
Impacted Files Coverage Δ
static/app/actionCreators/projects.tsx 72.52% <ø> (ø)
static/app/views/projectInstall/createProject.tsx 100.00% <ø> (ø)
...tic/app/views/projectInstall/issueAlertOptions.tsx 92.94% <ø> (-0.17%) ⬇️
static/app/views/projectInstall/platform.tsx 100.00% <ø> (ø)
...app/views/projectInstall/platformOrIntegration.tsx 0.00% <ø> (ø)
src/sentry/ingest/ingest_consumer.py 87.68% <80.76%> (-0.64%) ⬇️

... and 7 files with indirect coverage changes

@Swatinem Swatinem merged commit c30be03 into master Jun 1, 2023
@Swatinem Swatinem deleted the swatinem/ref-ingest branch June 1, 2023 10:41
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants