Skip to content

feat(functions): Include examples in functions trends timeseries#53003

Merged
Zylphrex merged 2 commits into
masterfrom
txiao/feat/include-examples-in-function-trends-timeseries
Jul 18, 2023
Merged

feat(functions): Include examples in functions trends timeseries#53003
Zylphrex merged 2 commits into
masterfrom
txiao/feat/include-examples-in-function-trends-timeseries

Conversation

@Zylphrex

@Zylphrex Zylphrex commented Jul 17, 2023

Copy link
Copy Markdown
Member

A simple list of examples isn't very meaningful in this context. We want a list of examples that can be associated with a timestamp. This adds a timeseries that includes up to 1 example profile per bucket in the roll up so that we can pick out examples at various points in time.

A simple list of examples isn't very meaningful in this context. We want a list
of examples that can be associated with a timestamp. This adds a timeseries that
includes up to 1 example profile per bucket in the roll up so that we can pick
out examples at various points in time.
@Zylphrex Zylphrex requested a review from a team July 17, 2023 19:59
@Zylphrex Zylphrex requested a review from a team as a code owner July 17, 2023 19:59
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 17, 2023
@Zylphrex Zylphrex requested a review from a team July 17, 2023 20:06
@codecov

codecov Bot commented Jul 17, 2023

Copy link
Copy Markdown

Codecov Report

Merging #53003 (835f5b2) into master (4ea79c8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #53003   +/-   ##
=======================================
  Coverage   79.45%   79.46%           
=======================================
  Files        4936     4936           
  Lines      207390   207439   +49     
  Branches    35423    35430    +7     
=======================================
+ Hits       164790   164837   +47     
- Misses      37565    37566    +1     
- Partials     5035     5036    +1     
Impacted Files Coverage Δ
...sentry/search/events/datasets/profile_functions.py 73.50% <ø> (ø)
.../api/endpoints/organization_profiling_functions.py 91.86% <100.00%> (ø)

... and 16 files with indirect coverage changes

@Zylphrex Zylphrex merged commit 988ede3 into master Jul 18, 2023
@Zylphrex Zylphrex deleted the txiao/feat/include-examples-in-function-trends-timeseries branch July 18, 2023 13:32
@sentry

sentry Bot commented Jul 24, 2023

Copy link
Copy Markdown
Contributor

Suspect Issues

This pull request has been deployed and Sentry has observed the following issues:

  • ‼️ IndexError: list index out of range /api/0/organizations/{organization_slug}/profil... View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions Bot locked and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants