Validate assemble_artifact arguments earlier#53333
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
loewenheim
reviewed
Jul 21, 2023
- Ensures that we always have a `Project` for ArtifactBundles - Ensures that there is always a release for a Releasebundle - Defaults the `bundle_id` earlier
Swatinem
force-pushed
the
swatinem/stricter-assemble
branch
from
0ef2f52 to
895852f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #53333 +/- ##
==========================================
- Coverage 79.55% 79.54% -0.01%
==========================================
Files 4942 4942
Lines 208639 208640 +1
Branches 35544 35546 +2
==========================================
- Hits 165975 165972 -3
- Misses 37605 37607 +2
- Partials 5059 5061 +2
|
Co-authored-by: Riccardo Busetti <riccardo.busetti@sentry.io>
iambriccardo
approved these changes
Jul 24, 2023
armenzg
pushed a commit
that referenced
this pull request
Jul 24, 2023
- Ensures that we always have a `Project` for ArtifactBundles - Ensures that there is always a release for a Releasebundle - Defaults the `bundle_id` earlier Co-authored-by: Riccardo Busetti <riccardo.busetti@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projectfor ArtifactBundlesbundle_idearlier