Skip to content

Comments

fix(hc): Support split db monolith mode via smarter delegators#53395

Merged
corps merged 5 commits intomasterfrom
zc/ensure-monolith-services-align-with-open-transactions
Jul 23, 2023
Merged

fix(hc): Support split db monolith mode via smarter delegators#53395
corps merged 5 commits intomasterfrom
zc/ensure-monolith-services-align-with-open-transactions

Conversation

@corps
Copy link
Contributor

@corps corps commented Jul 22, 2023

Same as https://github.com/getsentry/sentry/pull/53365/files but conditionalizing the testutil import to prevent issue in prod.

@corps corps requested a review from a team July 22, 2023 05:28
@corps corps changed the title Zc/ensure monolith services align with open transactions fix(hc): Support split db monolith mode via smarter delegators Jul 22, 2023
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 22, 2023
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #53395 (56e163d) into master (bf041f3) will decrease coverage by 1.72%.
The diff coverage is 74.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #53395      +/-   ##
==========================================
- Coverage   79.54%   77.83%   -1.72%     
==========================================
  Files        4940     4940              
  Lines      208184   208580     +396     
  Branches    35483    35542      +59     
==========================================
- Hits       165600   162344    -3256     
- Misses      37545    41170    +3625     
- Partials     5039     5066      +27     
Impacted Files Coverage Δ
src/sentry/services/hybrid_cloud/log/impl.py 74.19% <41.66%> (-2.28%) ⬇️
src/sentry/services/hybrid_cloud/__init__.py 88.02% <91.30%> (+0.43%) ⬆️

... and 271 files with indirect coverage changes

@corps corps enabled auto-merge (squash) July 23, 2023 22:38
@corps corps merged commit d16d615 into master Jul 23, 2023
@corps corps deleted the zc/ensure-monolith-services-align-with-open-transactions branch July 23, 2023 23:07
armenzg pushed a commit that referenced this pull request Jul 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants