feat(dashboards): enable on demand metric queries#54279
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
matejminar
approved these changes
Aug 8, 2023
| @@ -0,0 +1,42 @@ | |||
| import {FieldKey, MobileVital, WebVital} from 'sentry/utils/fields'; | |||
Member
There was a problem hiding this comment.
nit: we call these files constants.tsx
| generatePathname: isEditing ? fetchEstimatedStats : undefined, | ||
| }); | ||
|
|
||
| response[0] = {...response[0], isMetricsData: true, isExtrapolatedData: isEditing}; |
Member
There was a problem hiding this comment.
Does ...response[0] cause a hard crash if the request fails? Should we add some error handling?
Member
Author
There was a problem hiding this comment.
yep, i added a fallback to the original request
Comment on lines
+200
to
+203
| {t( | ||
| 'We don’t routinely collect metrics from this property. However, we’ll do so ' | ||
| )} | ||
| <b> {t('once this widget has been saved.')}</b> |
Member
There was a problem hiding this comment.
Let's use tct for it because this might not work for some languages. Example usage:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #54280
Closes https://github.com/getsentry/team-ingest/issues/191