Shorten commit message in commits tab#5446
Merged
Merged
Conversation
| } | ||
|
|
||
| let firstLine = message.split(/\n/)[0]; | ||
| if (firstLine.length > 100) { |
Contributor
There was a problem hiding this comment.
First lines in git are expected and anticipated to be 50 characters. Most git UI things use this.
Contributor
There was a problem hiding this comment.
I'd do this truncation in CSS ... cause we can do some style ellipsis stuff. I can show you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Truncates commit message in commits tab on first line or uses truncate class otherwise
Fixes #5444