fix: Slice on unevaluated QuerySet for Organization.has_single_owner#55715
Merged
Conversation
dashed
commented
Sep 5, 2023
| @@ -346,9 +346,11 @@ def default_owner_id(self): | |||
|
|
|||
| def has_single_owner(self): | |||
| owners = list( | |||
Member
Author
There was a problem hiding this comment.
Here, owners should return at most 2 records.
cathteng
approved these changes
Sep 5, 2023
cathteng
left a comment
Contributor
There was a problem hiding this comment.
thanks for catching this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this while fixing tests for split silos.
This was a regression from 131596d, and the implementation of
def has_single_ownerhad this optimization prior to the refactor: https://github.com/getsentry/sentry/blame/1acfc6443fa031fb932115c69ddbe12c01bd8b8e/src/sentry/models/organization.py#L310-L316Slicing on unevaluated QuerySet would add the appropriate
LIMITkeywords on the generated SQL query: