Skip to content

feat(am2-check): Add better query for project support and improve check #55971

Merged
iambriccardo merged 6 commits into
masterfrom
riccardo/feat/extend-am2-check
Sep 11, 2023
Merged

feat(am2-check): Add better query for project support and improve check #55971
iambriccardo merged 6 commits into
masterfrom
riccardo/feat/extend-am2-check

Conversation

@iambriccardo

@iambriccardo iambriccardo commented Sep 11, 2023

Copy link
Copy Markdown
Contributor

This PR improves the compatibility check script with two improvements:

  • The compatibility of projects is now determined with a new algorithm, since the old one was copied from another context that was out of date.
  • The incompatible SDKs will now only be marked as incompatible with AM2 if they support performance in the first place (code for this is currently commented out since its blocked on a list of SDKs that needs to be compiled).

Closes https://github.com/getsentry/team-ingest/issues/209

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 11, 2023
@iambriccardo iambriccardo changed the title riccardo/feat/extend am2 check feat(am2-check): Add better query for project support and improve check Sep 11, 2023
@codecov

codecov Bot commented Sep 11, 2023

Copy link
Copy Markdown

Codecov Report

Merging #55971 (3dbe6e1) into master (05be00d) will decrease coverage by 0.20%.
Report is 98 commits behind head on master.
The diff coverage is 47.05%.

@@            Coverage Diff             @@
##           master   #55971      +/-   ##
==========================================
- Coverage   80.14%   79.95%   -0.20%     
==========================================
  Files        5055     5061       +6     
  Lines      217213   217596     +383     
  Branches    36782    36835      +53     
==========================================
- Hits       174080   173973     -107     
- Misses      37782    38296     +514     
+ Partials     5351     5327      -24     
Files Changed Coverage
src/sentry/tasks/check_am2_compatibility.py 47.05%

@iambriccardo iambriccardo enabled auto-merge (squash) September 11, 2023 08:36
@iambriccardo iambriccardo merged commit c027b96 into master Sep 11, 2023
@iambriccardo iambriccardo deleted the riccardo/feat/extend-am2-check branch September 11, 2023 08:45
@sentry

sentry Bot commented Sep 11, 2023

Copy link
Copy Markdown
Contributor

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ KeyError: 'count_null_transactions()' sentry.tasks.check_am2_compatibility View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions Bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants