fix(profiling): compute label precision#55981
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
JonasBa
force-pushed
the
jb/fix/label-position
branch
from
c0b0c25 to
121a47d
Compare
JonasBa
commented
Sep 11, 2023
| const textOffset = 2 * window.devicePixelRatio; | ||
| const text = this.chart.formatter(intervals[i]); | ||
|
|
||
| if (text === lastIntervalTxt) { |
Contributor
Author
There was a problem hiding this comment.
If the labels are so small that the text matches exactly to what we rendered before, then skip drawing it.
phacops
approved these changes
Sep 11, 2023
viglia
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute chart precision based off domain range
