fix(metrics): Increase sample rate of internal metrics to 100%#55982
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
mitsuhiko
approved these changes
Sep 11, 2023
Codecov Report
@@ Coverage Diff @@
## master #55982 +/- ##
==========================================
- Coverage 79.95% 79.39% -0.56%
==========================================
Files 5060 5060
Lines 217580 217580
Branches 36833 36833
==========================================
- Hits 173963 172756 -1207
- Misses 38290 39382 +1092
- Partials 5327 5442 +115 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets sample rate to 100% for all internal metrics coming from minimetrics and improves handling of thread locals.