ui: various form improvements #5661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcramer
commented
Jun 29, 2017
package.json
Outdated
Member
Author
There was a problem hiding this comment.
this is a dupe of @billyvg's work, i can back it out, but it looks like he hadn't landed it yet and is OOO for a bit
Generated by 🚫 danger |
Member
Author
|
@benvinegar im going to merge this once its green as it includes some general refactor/cleanup/tests, but would like to follow up on the mock usage to see if you have opinions on improvements |
dcramer
force-pushed
the
ui/expand-tests
branch
5 times, most recently
from
73e4c5f to
694f5ca
Compare
- move ProjectAlertSettings to new forms - add mock capabilities for API - add default ConfigStore mock - expand AdminSettings snapshot test - fix onChange handler in RangeField - requireChanges on a few forms - add support for multiple queries in AsyncView
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.