workflow: fix various behavior with GroupSnooze#5743
Merged
Conversation
dcramer
commented
Jul 19, 2017
dcramer
commented
Member
- activity entry was showing wrong value for duration
- upon clearing of GroupSnooze, status was not reflected (fixes Ignore until occurs X times in Y interval not alerting once threshold is reached #5742)
- activity entry was showing wrong value for duration - upon clearing of GroupSnooze, status was not reflected (fixes GH-5742)
Generated by 🚫 danger |
dcramer
commented
Jul 19, 2017
| raise ValueError | ||
|
|
||
| if self.until: | ||
| if self.until > timezone.now(): |
Member
Author
There was a problem hiding this comment.
all of this just changes the behavior so if you specified multiple attributes here it would reflect them
its not really needed, but in the future maybe we'll want it
mattrobenolt
approved these changes
Jul 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.