feat(alerts): prevent creation of transaction alerts#58242
Merged
obostjancic merged 3 commits intoOct 18, 2023
Conversation
github-actions
Bot
added
the
Scope: Backend
RaduW
approved these changes
Oct 17, 2023
RaduW
left a comment
RaduW
left a comment
Contributor
There was a problem hiding this comment.
looks good to me.
Don't see any test for this though ? (maybe it doesn't make sense)
Codecov Report
@@ Coverage Diff @@
## master #58242 +/- ##
=======================================
Coverage 79.06% 79.06%
=======================================
Files 5140 5140
Lines 223798 223809 +11
Branches 37677 37680 +3
=======================================
+ Hits 176945 176960 +15
+ Misses 41182 41177 -5
- Partials 5671 5672 +1
|
obostjancic
deleted the
ogi/feat/prevent-transaction-alert-creation-be
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.