feat(starfish): Map device class back to the correct labels#58246
Merged
Conversation
wmak
commented
Oct 17, 2023
wmak
commented
Member
- The device.class field is stored as string numbers (1,2,3) that map back to a label (low,mid,high) this is so that we can keep the labels updated even as devices become outdated as time progresses
- The device.class field is stored as string numbers (1,2,3) that map back to a label (low,mid,high) this is so that we can keep the labels updated even as devices become outdated as time progresses
github-actions
Bot
added
the
Scope: Backend
shruthilayaj
approved these changes
Oct 17, 2023
shruthilayaj
left a comment
shruthilayaj
left a comment
Member
There was a problem hiding this comment.
LGTM, can you add this to spansIndexed too?
Member
|
Oh and we need it for transaction metrics too! |
Codecov Report
@@ Coverage Diff @@
## master #58246 +/- ##
==========================================
+ Coverage 78.62% 79.10% +0.48%
==========================================
Files 5142 5143 +1
Lines 224102 224125 +23
Branches 37735 37743 +8
==========================================
+ Hits 176201 177305 +1104
+ Misses 42171 41134 -1037
+ Partials 5730 5686 -44
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.