Skip to content

fix(discover): hardcoded timestamp in test#58272

Merged
DominikB2014 merged 2 commits into
masterfrom
DominikB2014/hardcoded-timestamp-test
Oct 17, 2023
Merged

fix(discover): hardcoded timestamp in test#58272
DominikB2014 merged 2 commits into
masterfrom
DominikB2014/hardcoded-timestamp-test

Conversation

@DominikB2014

@DominikB2014 DominikB2014 commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

Fixes a test that uses a hardcoded timestamp, which causes issues as the time is based off of a "day ago".
This test shouldn't care about the timestamps in the result, so we can just compare the count values directly.

@DominikB2014 DominikB2014 changed the title fix(test): hardcoded timestamp fix(discover): hardcoded timestamp in test Oct 17, 2023
@DominikB2014 DominikB2014 marked this pull request as ready for review October 17, 2023 18:12
@DominikB2014 DominikB2014 requested review from a team and john-z-yang October 17, 2023 18:12
@DominikB2014 DominikB2014 enabled auto-merge (squash) October 17, 2023 18:13
@DominikB2014 DominikB2014 merged commit e5c15d3 into master Oct 17, 2023
@DominikB2014 DominikB2014 deleted the DominikB2014/hardcoded-timestamp-test branch October 17, 2023 18:48
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants