Skip to content

feat(starfish): Add support for avg_if on metrics & span metrics#58306

Merged
shruthilayaj merged 1 commit into
masterfrom
shruthi/feat/add-support-for-avg-if
Oct 18, 2023
Merged

feat(starfish): Add support for avg_if on metrics & span metrics#58306
shruthilayaj merged 1 commit into
masterfrom
shruthi/feat/add-support-for-avg-if

Conversation

@shruthilayaj

Copy link
Copy Markdown
Member

We need to do avg_if on a few a couple duration metrics
scoped to a certain release for mobile starfish.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 17, 2023
@shruthilayaj shruthilayaj marked this pull request as ready for review October 17, 2023 23:07
@shruthilayaj shruthilayaj requested a review from a team October 17, 2023 23:07
@shruthilayaj shruthilayaj requested a review from a team as a code owner October 17, 2023 23:07
@shruthilayaj shruthilayaj requested a review from a team October 17, 2023 23:07
@codecov

codecov Bot commented Oct 17, 2023

Copy link
Copy Markdown

Codecov Report

Merging #58306 (b8fbdd7) into master (18884db) will decrease coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #58306      +/-   ##
==========================================
- Coverage   79.06%   79.06%   -0.01%     
==========================================
  Files        5139     5139              
  Lines      223784   223784              
  Branches    37675    37675              
==========================================
- Hits       176939   176933       -6     
- Misses      41176    41184       +8     
+ Partials     5669     5667       -2     
Files Coverage Δ
src/sentry/search/events/datasets/metrics.py 57.54% <ø> (ø)
src/sentry/search/events/datasets/spans_metrics.py 48.27% <ø> (ø)

... and 5 files with indirect coverage changes

@shruthilayaj shruthilayaj merged commit 229a475 into master Oct 18, 2023
@shruthilayaj shruthilayaj deleted the shruthi/feat/add-support-for-avg-if branch October 18, 2023 16:41
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants