fix(alert-rule): Stop creating external issue for alert rule test notifcation#58314
Merged
schew2381 merged 1 commit intoOct 18, 2023
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
Codecov Report
@@ Coverage Diff @@
## master #58314 +/- ##
=======================================
Coverage 79.06% 79.07%
=======================================
Files 5140 5140
Lines 223798 223799 +1
Branches 37677 37678 +1
=======================================
+ Hits 176945 176963 +18
+ Misses 41182 41171 -11
+ Partials 5671 5665 -6
|
schew2381
deleted the
seiji/fix/stop-creating-external-issue-for-sample-events
branch
schew2381
changed the title
schew2381
added a commit
that referenced
this pull request
Oct 24, 2023
Accidentally added in this extra line in #58314
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After you click
Send Test Notification, we actually create an external issue for the sample event. However, the sample event is not surfaced through the UI anywhere, and having an external issue actually stops you from sending multiple test events for different Jira issue types such as story, bug, etc.