Skip to content

fix(crons): Correctly casts slugs to strings for events + occurrences#58920

Merged
rjo100 merged 1 commit into
masterfrom
rjo100/fix-monitor-occurrence
Oct 27, 2023
Merged

fix(crons): Correctly casts slugs to strings for events + occurrences#58920
rjo100 merged 1 commit into
masterfrom
rjo100/fix-monitor-occurrence

Conversation

@rjo100

@rjo100 rjo100 commented Oct 27, 2023

Copy link
Copy Markdown
Contributor

Fixes tags that only send numeric slugs, which are invalid due to #58743

@rjo100 rjo100 requested a review from a team as a code owner October 27, 2023 01:24
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 27, 2023
@rjo100 rjo100 enabled auto-merge (squash) October 27, 2023 01:26
@rjo100 rjo100 disabled auto-merge October 27, 2023 01:47
@codecov

codecov Bot commented Oct 27, 2023

Copy link
Copy Markdown

Codecov Report

Merging #58920 (748d845) into master (e499633) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #58920   +/-   ##
=======================================
  Coverage   80.62%   80.62%           
=======================================
  Files        5154     5154           
  Lines      225766   225766           
  Branches    38035    38035           
=======================================
+ Hits       182015   182019    +4     
+ Misses      38194    38189    -5     
- Partials     5557     5558    +1     
Files Coverage Δ
src/sentry/monitors/logic/mark_failed.py 95.72% <ø> (ø)

... and 7 files with indirect coverage changes

@rjo100 rjo100 merged commit 70debc6 into master Oct 27, 2023
@rjo100 rjo100 deleted the rjo100/fix-monitor-occurrence branch October 27, 2023 15:43
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants