Skip to content

fix(dashboard): Widget validation should accept environment#58930

Merged
narsaynorath merged 1 commit into
masterfrom
nar/fix/dashboard-widget-validation-should-accept-environment
Oct 27, 2023
Merged

fix(dashboard): Widget validation should accept environment#58930
narsaynorath merged 1 commit into
masterfrom
nar/fix/dashboard-widget-validation-should-accept-environment

Conversation

@narsaynorath

@narsaynorath narsaynorath commented Oct 27, 2023

Copy link
Copy Markdown
Member

Some filter parameters have a requirement that a single environment is selected (e.g. release.stage). This passes along environment so that it is taken into account when resolving the conditions

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 27, 2023
@narsaynorath
fix(dashboard): Widget validation should accept environment
c30068c 
Some filter parameters have a requirement that a single environment is
selected (e.g. release.stage). This passes along environment so that it
is taken into account when resolving the conditions
@narsaynorath narsaynorath force-pushed the nar/fix/dashboard-widget-validation-should-accept-environment branch from 310f511 to c30068c Compare October 27, 2023 14:24
@narsaynorath narsaynorath mentioned this pull request Oct 27, 2023
Merged
@narsaynorath narsaynorath marked this pull request as ready for review October 27, 2023 14:29
@narsaynorath narsaynorath requested a review from a team October 27, 2023 14:29
@narsaynorath narsaynorath enabled auto-merge (squash) October 27, 2023 14:31
narsaynorath added a commit that referenced this pull request Oct 27, 2023
@narsaynorath
fix(dashboards): Pass along environment with validation request (#58934)
a042a85 
There are some filters (e.g. `release.stage`) that require the user to
filter to a specific environment. This passes along the environment
param so it can be processed with the filters for validation. The
backend filtering has a corresponding PR (#58930)

Closes #58929
@narsaynorath narsaynorath merged commit b9ea0b1 into master Oct 27, 2023
@narsaynorath narsaynorath deleted the nar/fix/dashboard-widget-validation-should-accept-environment branch October 27, 2023 15:15
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wmak wmak wmak approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@narsaynorath @wmak