Release status health api fixes#59163
Merged
Merged
Conversation
nhsiehgit
requested review from
a team,
cathteng,
schew2381 and
sentaur-athena
github-actions
Bot
added
the
Scope: Backend
Codecov Report
@@ Coverage Diff @@
## master #59163 +/- ##
==========================================
+ Coverage 80.64% 80.65% +0.01%
==========================================
Files 5157 5157
Lines 226049 226062 +13
Branches 38078 38080 +2
==========================================
+ Hits 182293 182339 +46
+ Misses 38185 38151 -34
- Partials 5571 5572 +1
|
cathteng
approved these changes
Nov 1, 2023
| release_id = serializers.ListField( | ||
| required=False, allow_empty=True, child=serializers.IntegerField() | ||
| ) | ||
| release = serializers.ListField(required=False, allow_empty=True, child=serializers.CharField()) |
Contributor
There was a problem hiding this comment.
nit: maybe call this release_version or version?
Contributor
Author
There was a problem hiding this comment.
I'll update the help text to describe this.
Opting to keep it the shorter 'release' since typically you would reference a release by its version anyways
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into an issue where if an environment does not exist on a threshold, then the api response would fail to construct a response.
Also realized that querying via release id is not useful, and instead we want to allow for querying by release version