threshold observability#59359
Merged
Merged
Conversation
nhsiehgit
requested review from
a team,
cathteng,
schew2381 and
sentaur-athena
github-actions
Bot
added
the
Scope: Backend
cathteng
approved these changes
Nov 3, 2023
nhsiehgit
commented
Nov 3, 2023
| "start": release.date, # deploy.date_finished _would_ be more accurate, but is not keyed on project so cannot be used | ||
| "end": release.date | ||
| + timedelta(threshold.window_in_seconds), # start + threshold.window | ||
| + timedelta( |
Contributor
Author
There was a problem hiding this comment.
This is actually a functional change bug fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add loggers + metrics for release threshold health api