Skip to content

feat(profiling): add differential flamegraph toolbar#61140

Merged
JonasBa merged 15 commits into
masterfrom
jb/feat/differential-flamegraph-toolbar
Dec 5, 2023
Merged

feat(profiling): add differential flamegraph toolbar#61140
JonasBa merged 15 commits into
masterfrom
jb/feat/differential-flamegraph-toolbar

Conversation

@JonasBa

@JonasBa JonasBa commented Dec 5, 2023

Copy link
Copy Markdown
Contributor

Add toolbar to differential flamegraph

CleanShot 2023-12-05 at 11 29 25@2x

@JonasBa JonasBa requested a review from a team as a code owner December 5, 2023 16:30
@JonasBa JonasBa requested a review from a team December 5, 2023 16:30
@JonasBa JonasBa requested a review from a team as a code owner December 5, 2023 16:30
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 5, 2023
Base automatically changed from jb/feat/differential-flamegraph-loading-states to master December 5, 2023 19:02
</FlamegraphStateProvider>
</FlamegraphThemeProvider>
</div>
</Fragment>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Fragment looks redundant

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it yeah, but it's required. The children prop indentation makes it look off

@JonasBa JonasBa merged commit 47d524c into master Dec 5, 2023
@JonasBa JonasBa deleted the jb/feat/differential-flamegraph-toolbar branch December 5, 2023 23:14
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants