Skip to content

docs(stories): Add an icon for files inside the storybook tree#61166

Merged
ryan953 merged 2 commits into
masterfrom
ryan953/storybook-file-icon
Dec 5, 2023
Merged

docs(stories): Add an icon for files inside the storybook tree#61166
ryan953 merged 2 commits into
masterfrom
ryan953/storybook-file-icon

Conversation

@ryan953

@ryan953 ryan953 commented Dec 5, 2023

Copy link
Copy Markdown
Member
SCR-20231205-kdxp

@ryan953 ryan953 requested a review from JonasBa December 5, 2023 18:59
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 5, 2023
@JonasBa

JonasBa commented Dec 5, 2023

Copy link
Copy Markdown
Contributor

Nice, def clearer. Could we also make the indentation at the same level? Right now it still looks like files are the children of the parent folder.

For example this is how vscode renders the fs hierarchy
CleanShot 2023-12-05 at 14 05 37@2x

In our case it looks like it's indented a level deeper
CleanShot 2023-12-05 at 14 07 03@2x

@ryan953

ryan953 commented Dec 5, 2023

Copy link
Copy Markdown
Member Author

@JonasBa updated the screenshot in the desc ^

@JonasBa

JonasBa commented Dec 5, 2023

Copy link
Copy Markdown
Contributor

Nice, much better, thank you!

@ryan953 ryan953 enabled auto-merge (squash) December 5, 2023 19:16
@ryan953 ryan953 merged commit d22b3de into master Dec 5, 2023
@ryan953 ryan953 deleted the ryan953/storybook-file-icon branch December 5, 2023 19:30
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants