Skip to content

feat(severity): Create a new "high priority" alert#61186

Merged
snigdhas merged 10 commits into
masterfrom
snigdha/severity-condition
Dec 6, 2023
Merged

feat(severity): Create a new "high priority" alert#61186
snigdhas merged 10 commits into
masterfrom
snigdha/severity-condition

Conversation

@snigdhas
Copy link
Copy Markdown
Contributor

@snigdhas snigdhas commented Dec 5, 2023

Adds a new alert condition, HIghPriorityIssueCondition, which evaluated to true if:

  • an issue is high severity (> 0.1 severity score)
  • an archived issue escalatings
  • a new issue (< 1 day old) is detected as escalating
image image

Up next - further testing in a personal project, checking the email formatting and reason

Fixes #59872

@snigdhas snigdhas requested review from a team and ceorourke December 5, 2023 21:12
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 5, 2023
@snigdhas snigdhas marked this pull request as ready for review December 5, 2023 21:25
Comment thread src/sentry/api/endpoints/project_rules_configuration.py
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 5, 2023

Codecov Report

Merging #61186 (cc37678) into master (ada0212) will increase coverage by 27.90%.
Report is 1 commits behind head on master.
The diff coverage is 83.33%.

❗ Current head cc37678 differs from pull request most recent head ac8ce3d. Consider uploading reports for the commit ac8ce3d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #61186       +/-   ##
===========================================
+ Coverage   53.17%   81.08%   +27.90%     
===========================================
  Files        4288     5186      +898     
  Lines      176775   227771    +50996     
  Branches    29747    38219     +8472     
===========================================
+ Hits        93996   184682    +90686     
+ Misses      81608    37465    -44143     
- Partials     1171     5624     +4453     
Files Coverage Δ
...entry/api/endpoints/project_rules_configuration.py 96.66% <100.00%> (ø)
src/sentry/conf/server.py 89.47% <ø> (-0.28%) ⬇️
src/sentry/features/__init__.py 100.00% <100.00%> (ø)
src/sentry/rules/conditions/high_priority_issue.py 81.25% <81.25%> (ø)

... and 2097 files with indirect coverage changes

Comment thread src/sentry/rules/conditions/high_priority_issue.py Outdated
Comment thread src/sentry/rules/conditions/high_priority_issue.py
Base automatically changed from snigdha/has_escalated to master December 5, 2023 23:28
Comment thread src/sentry/rules/conditions/high_priority_issue.py
snigdhas added a commit that referenced this pull request Dec 6, 2023
…us change (#61217)

Set the Activity and GroupHistory when setting new groups to escalating.

From
#61186 (comment)

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
@snigdhas snigdhas merged commit 4922319 into master Dec 6, 2023
@snigdhas snigdhas deleted the snigdha/severity-condition branch December 6, 2023 21:32
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a high priority condition for alert rules

3 participants