Skip to content

feat(severity): Set the Activity and GroupHistory for escalating status change #61217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snigdhas merged 4 commits into from
Dec 6, 2023
Merged

feat(severity): Set the Activity and GroupHistory for escalating status change #61217

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3351f4b
Set Activity and GroupHistory for status change
snigdhas Dec 6, 2023
344eacc
Merge branch 'master' into snigdha/escalating-activity
snigdhas Dec 6, 2023
6079fdc
:hammer_and_wrench: apply pre-commit fixes
getsantry[bot] Dec 6, 2023
46a67b6
Update post_process.py
snigdhas Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/sentry/tasks/post_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1356,7 +1356,10 @@ def detect_new_escalation(job: PostProcessJob):
job.
"""
from sentry.issues.issue_velocity import get_latest_threshold
from sentry.models.activity import Activity
from sentry.models.grouphistory import GroupHistoryStatus, record_group_history
from sentry.models.groupinbox import GroupInboxReason, add_group_to_inbox
from sentry.types.activity import ActivityType

group = job["event"].group
if not group or not features.has(
Expand All @@ -1382,7 +1385,15 @@ def detect_new_escalation(job: PostProcessJob):
if project_escalation_rate > 0 and group_hourly_event_rate > project_escalation_rate:
job["has_escalated"] = True
group.update(substatus=GroupSubStatus.ESCALATING)

# TODO(snigdha): reuse manage_issue_states when we allow escalating from other statuses
add_group_to_inbox(group, GroupInboxReason.ESCALATING)
record_group_history(group, GroupHistoryStatus.ESCALATING)
Activity.objects.create_group_activity(
group=group,
type=ActivityType.SET_ESCALATING,
data={"event_id": job["event"].event_id},
)
except UnableToAcquireLock as error:
extra["error"] = error
logger.warning(
Expand Down