feat(ddm): Add widget selection#61242
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
…-widget-selection
ArthurKnaus
commented
Dec 6, 2023
Comment on lines
+436
to
438
| if ([0, Infinity, -Infinity, NaN].includes(value)) { | ||
| return value.toLocaleString(); | ||
| } |
Member
Author
There was a problem hiding this comment.
Ran into a case were some values were Infinite in ddm. Not sure if that is a bug or not 😅
Either way this util should be defensive about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ddm context with widget selection state.
Add empty state to tray.
Memoize props and some components to improve performance.