Skip to content

ref: Sort feature flags alphabetically#61327

Merged
schew2381 merged 8 commits into
masterfrom
seiji/ref/sort-some-server-stuff
Dec 7, 2023
Merged

ref: Sort feature flags alphabetically#61327
schew2381 merged 8 commits into
masterfrom
seiji/ref/sort-some-server-stuff

Conversation

@schew2381

@schew2381 schew2381 commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

This has been bothering me for a while now, finally sorted them

Extra line comes from comment to the top:
NOTE: Please maintain alphabetical order when adding new feature flags

@schew2381 schew2381 self-assigned this Dec 7, 2023
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 7, 2023
@codecov

codecov Bot commented Dec 7, 2023

Copy link
Copy Markdown

Codecov Report

Merging #61327 (c62baa3) into master (e1dce4a) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #61327   +/-   ##
=======================================
  Coverage   81.07%   81.07%           
=======================================
  Files        5186     5186           
  Lines      227817   227817           
  Branches    38221    38221           
=======================================
+ Hits       184710   184711    +1     
  Misses      37478    37478           
+ Partials     5629     5628    -1     
Files Coverage Δ
src/sentry/conf/server.py 89.91% <ø> (ø)

... and 6 files with indirect coverage changes

@schew2381 schew2381 requested a review from a team December 7, 2023 01:50
@schew2381 schew2381 changed the title ref: Sort server fields that are able to be sorted ref: Sort feature flags alphabetically Dec 7, 2023
@schew2381 schew2381 force-pushed the seiji/ref/sort-some-server-stuff branch from 4cf39fd to f2e56b9 Compare December 7, 2023 01:51
@schew2381 schew2381 marked this pull request as ready for review December 7, 2023 01:51
@schew2381 schew2381 requested a review from cathteng December 7, 2023 01:51

@nhsiehgit nhsiehgit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scary change.
not quite sure how to validate it so just gonna trust 😨

@schew2381 schew2381 merged commit 8c5d932 into master Dec 7, 2023
@schew2381 schew2381 deleted the seiji/ref/sort-some-server-stuff branch December 7, 2023 16:17
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants