ref: Sort feature flags alphabetically#61327
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #61327 +/- ##
=======================================
Coverage 81.07% 81.07%
=======================================
Files 5186 5186
Lines 227817 227817
Branches 38221 38221
=======================================
+ Hits 184710 184711 +1
Misses 37478 37478
+ Partials 5629 5628 -1
|
4cf39fd to
f2e56b9
Compare
nhsiehgit
approved these changes
Dec 7, 2023
nhsiehgit
left a comment
Contributor
There was a problem hiding this comment.
scary change.
not quite sure how to validate it so just gonna trust 😨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been bothering me for a while now, finally sorted them
Extra line comes from comment to the top:
NOTE: Please maintain alphabetical order when adding new feature flags