fix: Add stacktrace form exception to raw report#6220
Merged
Conversation
mitsuhiko
suggested changes
Sep 29, 2017
| def get_threads_apple_string(self): | ||
| rv = [] | ||
| for thread in self.threads or []: | ||
| for thread in (self.exception + self.threads) or []: |
Contributor
There was a problem hiding this comment.
This can be None + [] which will fail (or the other way round).
Contributor
There was a problem hiding this comment.
Also since this is now different objects i would at least not call it thread (code now assumes either thread or exception).
Generated by 🚫 danger |
mitsuhiko
approved these changes
Sep 29, 2017
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.