feat(backup): Add EqualOrRemovedComparator#62699
Merged
azaslavsky merged 1 commit intomasterfrom Jan 10, 2024
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #62699 +/- ##
===========================================
+ Coverage 56.52% 81.30% +24.78%
===========================================
Files 5191 5201 +10
Lines 230171 230430 +259
Branches 39774 39823 +49
===========================================
+ Hits 130101 187358 +57257
+ Misses 96070 37328 -58742
- Partials 4000 5744 +1744
|
azaslavsky
force-pushed
the
az/equal-or-removed-comparator
branch
from
748badd to
a7774cb
Compare
hubertdeng123
approved these changes
Jan 9, 2024
Recently, we've added a couple of import handlers where we selectively null out fields based on certain conditions (see: PRs 62665 and 62526). This commit adds comparator support for this condition, allowing us to define comparators that say "make sure these fields are either equal or have been removed on the right side".
azaslavsky
force-pushed
the
az/equal-or-removed-comparator
branch
from
d7b652f to
7c99f5e
Compare
trillville
pushed a commit
that referenced
this pull request
Jan 19, 2024
Recently, we've added a couple of import handlers where we selectively null out fields based on certain conditions (see: PRs #62665 and #62526). This commit adds comparator support for this condition, allowing us to define comparators that say "make sure these fields are either equal or have been removed on the right side".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, we've added a couple of import handlers where we selectively null out fields based on certain conditions (see: PRs #62665 and #62526). This commit adds comparator support for this condition, allowing us to define comparators that say "make sure these fields are either equal or have been removed on the right side".