Skip to content

feat(relocation): Add relocation created analytics#62880

Merged
hubertdeng123 merged 8 commits into
masterfrom
hubertdeng123/add-relocation-analytics
Jan 10, 2024
Merged

feat(relocation): Add relocation created analytics#62880
hubertdeng123 merged 8 commits into
masterfrom
hubertdeng123/add-relocation-analytics

Conversation

@hubertdeng123

@hubertdeng123 hubertdeng123 commented Jan 9, 2024

Copy link
Copy Markdown
Contributor

Adds a couple of analytics that will be helpful in the context of relocations.

  1. Orgs that are created during the relocation process
  2. Relocations that are kicked off

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 9, 2024
@codecov

codecov Bot commented Jan 9, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6f21f54) 81.33% compared to head (a1cafae) 81.35%.
Report is 81 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #62880      +/-   ##
==========================================
+ Coverage   81.33%   81.35%   +0.02%     
==========================================
  Files        5201     5203       +2     
  Lines      230436   230700     +264     
  Branches    39821    39867      +46     
==========================================
+ Hits       187420   187681     +261     
+ Misses      37266    37265       -1     
- Partials     5750     5754       +4     
Files Coverage Δ
src/sentry/analytics/events/user_signup.py 100.00% <100.00%> (ø)
src/sentry/api/endpoints/relocations/index.py 94.96% <100.00%> (+0.03%) ⬆️
src/sentry/api/endpoints/relocations/retry.py 96.42% <100.00%> (+0.13%) ⬆️
src/sentry/tasks/relocation.py 88.39% <71.42%> (-0.29%) ⬇️

... and 48 files with indirect coverage changes

@hubertdeng123 hubertdeng123 marked this pull request as ready for review January 10, 2024 19:17
@hubertdeng123 hubertdeng123 requested review from a team and azaslavsky January 10, 2024 19:17
Comment thread src/sentry/analytics/events/organization_imported.py Outdated
Comment thread src/sentry/api/endpoints/relocations/index.py
Comment thread src/sentry/analytics/events/organization_imported.py
Comment thread src/sentry/analytics/events/relocation_created.py Outdated
Comment thread tests/sentry/tasks/test_relocation.py
Comment thread src/sentry/tasks/relocation.py Outdated
owner_id=relocation.owner_id,
)
except Exception as e:
capture_exception(e)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the capture bit here, good idea.

@hubertdeng123 hubertdeng123 merged commit 7bd76fd into master Jan 10, 2024
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/add-relocation-analytics branch January 10, 2024 23:57
trillville pushed a commit that referenced this pull request Jan 19, 2024
Adds a couple of analytics that will be helpful in the context of
relocations.

1. Orgs that are created during the relocation process
2. Relocations that are kicked off
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants