Skip to content

feat(ddm): Add support for OR in metrics api#64036

Merged
iambriccardo merged 1 commit intomasterfrom
riccardo/feat/add-support-or
Jan 29, 2024
Merged

feat(ddm): Add support for OR in metrics api#64036
iambriccardo merged 1 commit intomasterfrom
riccardo/feat/add-support-or

Conversation

@iambriccardo
Copy link
Copy Markdown
Contributor

@iambriccardo iambriccardo commented Jan 29, 2024

This PR adds the support of OR in the metrics API.

Closes #63675

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 29, 2024
@iambriccardo iambriccardo marked this pull request as ready for review January 29, 2024 10:47
@iambriccardo iambriccardo requested a review from a team as a code owner January 29, 2024 10:47
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ef6df1) 81.23% compared to head (da6ad9c) 81.23%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #64036      +/-   ##
==========================================
- Coverage   81.23%   81.23%   -0.01%     
==========================================
  Files        5227     5227              
  Lines      230424   230437      +13     
  Branches    45232    45235       +3     
==========================================
+ Hits       187185   187186       +1     
- Misses      37387    37394       +7     
- Partials     5852     5857       +5     
Files Coverage Δ
src/sentry/sentry_metrics/querying/visitors.py 77.45% <100.00%> (-1.45%) ⬇️

... and 11 files with indirect coverage changes

@iambriccardo iambriccardo merged commit 658eeb8 into master Jan 29, 2024
@iambriccardo iambriccardo deleted the riccardo/feat/add-support-or branch January 29, 2024 11:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow ORs in DDM

2 participants