feat(ddm): Add samples fallback query#64143
Merged
ArthurKnaus merged 1 commit intomasterfrom Jan 30, 2024
Merged
Conversation
github-actions
bot
added
the
Scope: Frontend
obostjancic
approved these changes
Jan 30, 2024
snigdhas
pushed a commit
that referenced
this pull request
Jan 30, 2024
Add fallback request for fetching samples. Pass query parameter to samples request in chart. Log timeouts with `ddm.correlated_samples.timeout` counter. The timeout on the FE is 15 seconds after that we will show samples of the last hour of the selected timeframe. The timeout mechanism is only enabled if the selected timeframe is bigger than 1 hour. - closes #64057
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add fallback request for fetching samples.
Pass query parameter to samples request in chart.
Log timeouts with
ddm.correlated_samples.timeoutcounter.The timeout on the FE is 15 seconds after that we will show samples of the last hour of the selected timeframe.
The timeout mechanism is only enabled if the selected timeframe is bigger than 1 hour.
This is supposed to be a temporary measure until the endpoint is faster