Skip to content

feat(settings): table style#64159

Merged
obostjancic merged 1 commit intomasterfrom
ogi/fix/metric-settins-table-style
Jan 30, 2024
Merged

feat(settings): table style#64159
obostjancic merged 1 commit intomasterfrom
ogi/fix/metric-settins-table-style

Conversation

@obostjancic
Copy link
Copy Markdown
Member

@obostjancic obostjancic commented Jan 30, 2024 •
edited
Loading

  • fixes table style
  • adds permissions checks
  • updates confirm text

@obostjancic obostjancic requested a review from a team as a code owner January 30, 2024 11:55
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 30, 2024
obostjancic
obostjancic commented Jan 30, 2024
View reviewed changes
static/app/views/settings/projectMetrics/access.tsx
Copy link
Copy Markdown
Member Author

@obostjancic obostjancic Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created from Access HOC. Will be moved to common utils in a followup PR

@obostjancic obostjancic merged commit 8c6d328 into master Jan 30, 2024
@obostjancic obostjancic deleted the ogi/fix/metric-settins-table-style branch January 30, 2024 12:52
snigdhas pushed a commit that referenced this pull request Jan 30, 2024
@obostjancic @snigdhas
feat(settings): table style (#64159)
797a609
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matejminar matejminar matejminar approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@obostjancic @matejminar