ref: Remove transaction_start from MSTeams integration#64167
Merged
szokeasaurusrex merged 3 commits intomasterfrom Jan 30, 2024
Merged
ref: Remove transaction_start from MSTeams integration#64167szokeasaurusrex merged 3 commits intomasterfrom
transaction_start from MSTeams integration#64167szokeasaurusrex merged 3 commits intomasterfrom
Conversation
Using `transaction_start` in the MSTeams integration routes is unnecessary and causes undefined behavior. All the routes in this integration are already automatically instrumented by the Django integration, and the auto-instrumented transactions can be viewed [here](https://sentry.sentry.io/performance/?isDefaultQuery=false&metricSearchSetting=metricsOnly&project=1&query=%2Fextensions%2Fmsteams%2F%2A&statsPeriod=24h). ref #63951
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #64167 +/- ##
==========================================
+ Coverage 77.67% 81.25% +3.57%
==========================================
Files 5233 5234 +1
Lines 230442 230447 +5
Branches 45210 45205 -5
==========================================
+ Hits 179007 187250 +8243
+ Misses 45307 37356 -7951
+ Partials 6128 5841 -287
|
szokeasaurusrex
changed the title
transaction_start from MSTeams integrationtransaction_start from MSTeams integration
snigdhas
pushed a commit
that referenced
this pull request
Jan 30, 2024
Using `transaction_start` in the MSTeams integration routes is unnecessary and causes undefined behavior. All the routes in this integration are already automatically instrumented by the Django integration, and the auto-instrumented transactions can be viewed [here](https://sentry.sentry.io/performance/?isDefaultQuery=false&metricSearchSetting=metricsOnly&project=1&query=%2Fextensions%2Fmsteams%2F%2A&statsPeriod=24h). ref #63951
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
transaction_startin the MSTeams integration routes is unnecessary and causes undefined behavior. All the routes in this integration are already automatically instrumented by the Django integration, and the auto-instrumented transactions can be viewed here.ref #63951