Skip to content

chore(hybridcloud) Handle ConnectionError when retries fail#64173

Merged
markstory merged 2 commits intomasterfrom
chore-handle-connection-error
Jan 30, 2024
Merged

chore(hybridcloud) Handle ConnectionError when retries fail#64173
markstory merged 2 commits intomasterfrom
chore-handle-connection-error

Conversation

@markstory
Copy link
Copy Markdown
Member

Handle ConnectionError from requests when retries fail. Converting to a RpcRemoteException will give us better grouping than ConnectionError would.

Handle ConnectionError from requests when retries fail. Converting to
a RpcRemoteException will give us better grouping than ConnectionError
would.
@markstory markstory requested a review from a team as a code owner January 30, 2024 15:18
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 30, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (efa5a83) 81.25% compared to head (23f14ff) 81.25%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #64173   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files        5234     5234           
  Lines      230456   230467   +11     
  Branches    45210    45213    +3     
=======================================
+ Hits       187263   187277   +14     
+ Misses      37355    37354    -1     
+ Partials     5838     5836    -2     
Files Coverage Δ
src/sentry/services/hybrid_cloud/rpc.py 87.74% <0.00%> (-1.18%) ⬇️

... and 15 files with indirect coverage changes

@markstory markstory merged commit c3ec7ff into master Jan 30, 2024
@markstory markstory deleted the chore-handle-connection-error branch January 30, 2024 17:01
snigdhas pushed a commit that referenced this pull request Jan 30, 2024
Handle ConnectionError from requests when retries fail. Converting to a
RpcRemoteException will give us better grouping than ConnectionError
would.
@sentry
Copy link
Copy Markdown
Contributor

sentry bot commented Feb 2, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ RpcRemoteException: organization.send_sso_link_emails: RPC Connection failed sentry.tasks.send_sso_link_emails_control View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants