chore(hybridcloud) Handle ConnectionError when retries fail#64173
Merged
chore(hybridcloud) Handle ConnectionError when retries fail#64173
Conversation
Handle ConnectionError from requests when retries fail. Converting to a RpcRemoteException will give us better grouping than ConnectionError would.
mrduncan
approved these changes
Jan 30, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #64173 +/- ##
=======================================
Coverage 81.25% 81.25%
=======================================
Files 5234 5234
Lines 230456 230467 +11
Branches 45210 45213 +3
=======================================
+ Hits 187263 187277 +14
+ Misses 37355 37354 -1
+ Partials 5838 5836 -2
|
snigdhas
pushed a commit
that referenced
this pull request
Jan 30, 2024
Handle ConnectionError from requests when retries fail. Converting to a RpcRemoteException will give us better grouping than ConnectionError would.
Contributor
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle ConnectionError from requests when retries fail. Converting to a RpcRemoteException will give us better grouping than ConnectionError would.