ref: Remove transaction_start from Pipeline Advancer#64179
Merged
szokeasaurusrex merged 1 commit intoJan 31, 2024
Conversation
Using `transaction_start` is unnecessary here, since this is a route handler already auto-instrumented by the Django integration. The auto-instrumented transactions can be viewed [here](https://sentry.sentry.io/performance/?isDefaultQuery=false&metricSearchSetting=metricsOnly&project=1&query=transaction%3A%22%2Fextensions%2F%7Bprovider_id%7D%2Fsetup%2F%22&statsPeriod=1h).
github-actions
Bot
added
the
Scope: Backend
3 tasks
szokeasaurusrex
changed the title
transaction_start from Pipeline Advancertransaction_start from Pipeline Advancer
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #64179 +/- ##
=======================================
Coverage 81.25% 81.25%
=======================================
Files 5234 5234
Lines 230456 230476 +20
Branches 45210 45215 +5
=======================================
+ Hits 187263 187282 +19
+ Misses 37355 37353 -2
- Partials 5838 5841 +3
|
sl0thentr0py
approved these changes
Jan 31, 2024
szokeasaurusrex
deleted the
szokeasaurusrex/tx-start-pipeline-advancer
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
transaction_startis unnecessary here, since this is a route handler already auto-instrumented by the Django integration. The auto-instrumented transactions can be viewed here.ref #63951
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.