feat(ci): Adding required migration approval from codeowners#64223
feat(ci): Adding required migration approval from codeowners#64223IanWoodard wants to merge 13 commits into
Conversation
github-actions
Bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #64223 +/- ##
=======================================
Coverage 81.27% 81.27%
=======================================
Files 5233 5233
Lines 230458 230458
Branches 45206 45206
=======================================
+ Hits 187305 187308 +3
+ Misses 37315 37312 -3
Partials 5838 5838 |
| - name: getsentry token | ||
| uses: getsentry/action-github-app-token@97c9e23528286821f97fba885c1b1123284b29cc # v2.0.0 | ||
| id: getsentry | ||
| with: | ||
| app_id: ${{ vars.SENTRY_INTERNAL_APP_ID }} | ||
| private_key: ${{ secrets.SENTRY_INTERNAL_APP_PRIVATE_KEY }} |
There was a problem hiding this comment.
this will fail for external contributors -- but that's probably fine
| check-migration-approval: | ||
| name: check if migration is approved | ||
| runs-on: ubuntu-22.04 | ||
| timeout-minutes: 3 | ||
| needs: did-migration-change | ||
| if: needs.did-migration-change.outputs.added == 'true' | ||
| steps: | ||
| - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3.1.0 | ||
| with: | ||
| persist-credentials: false |
There was a problem hiding this comment.
this won't work. it needs to re-trigger on approval somehow -- this only runs on push
There was a problem hiding this comment.
Yep, I was just using this as a means of testing. I am planning on moving this to a separate workflow 👍🏻
2 participants
Updating the GitHub workflows to require approval from owners-migrations before merging a migration.