ref(grouping): Add check for suppress_unnecessary_secondary_hash flag#64312
Merged
lobsterkatie merged 2 commits intomasterfrom Jan 31, 2024
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
30 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #64312 +/- ##
==========================================
- Coverage 81.27% 81.27% -0.01%
==========================================
Files 5236 5236
Lines 230537 230536 -1
Branches 45229 45229
==========================================
- Hits 187370 187362 -8
- Misses 37323 37330 +7
Partials 5844 5844 |
armenzg
approved these changes
Jan 31, 2024
src/sentry/event_manager.py
Outdated
Member
There was a problem hiding this comment.
I believe this would be more appropriate return type
Suggested change
| def assign_event_to_group(event: Event, job: Job, metric_tags: MutableTags) -> Optional[GroupInfo]: | |
| def assign_event_to_group(event: Event, job: Job, metric_tags: MutableTags) -> GroupInfo | None: |
Member
There was a problem hiding this comment.
You can follow this up on the next PR if you want to merge it now
Member
Author
There was a problem hiding this comment.
Oh, yeah, I guess we can do that now, without even using __future__, huh? Yay for finally being off of Python 3.8!
lobsterkatie
force-pushed
the
kmclb-add-check-for-suppress-unnecessary-secondary-hash-flag
branch
from
8d776c4 to
e61e526
Compare
lobsterkatie
deleted the
kmclb-add-check-for-suppress-unnecessary-secondary-hash-flag
branch
Contributor
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
lobsterkatie
added
the
Trigger: Revert
Contributor
|
PR reverted: 1f95319 |
lobsterkatie
added a commit
that referenced
this pull request
Feb 2, 2024
…ag (#64410) NOTE: This is a redo of #64312, which got reverted when it seemed it might be causing an error. Turns out it wasn't to blame, so pushing it through again. --------- This wraps `_save_aggregate` (whose logic is going to be updated in a new version of the function) in a new function, `assign_event_to_group`, which determines whether to run the current version or the new version. Which version to run is controlled both by the `suppress_unnecessary_secondary_hash` flag added in #64128 and by the project's grouping configs - any project using the mobile config as either their primary or secondary config has to use the current logic, since the new logic won't include any of the hierarchical grouping code. Note: For now both branches call the current version of `_save_aggregate`, as the new version has yet to be written. In addition, two bits of logic from `save_error_events`, which set group data on the event and the job, have been moved into the new wrapper.
cmanallen
pushed a commit
that referenced
this pull request
Feb 7, 2024
…ag (#64410) NOTE: This is a redo of #64312, which got reverted when it seemed it might be causing an error. Turns out it wasn't to blame, so pushing it through again. --------- This wraps `_save_aggregate` (whose logic is going to be updated in a new version of the function) in a new function, `assign_event_to_group`, which determines whether to run the current version or the new version. Which version to run is controlled both by the `suppress_unnecessary_secondary_hash` flag added in #64128 and by the project's grouping configs - any project using the mobile config as either their primary or secondary config has to use the current logic, since the new logic won't include any of the hierarchical grouping code. Note: For now both branches call the current version of `_save_aggregate`, as the new version has yet to be written. In addition, two bits of logic from `save_error_events`, which set group data on the event and the job, have been moved into the new wrapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wraps
_save_aggregate(whose logic is going to be updated in a new version of the function) in a new function,assign_event_to_group, which determines whether to run the current version or the new version. Which version to run is controlled both by thesuppress_unnecessary_secondary_hashflag added in #64128 and by the project's grouping configs - any project using the mobile config as either their primary or secondary config has to use the current logic, since the new logic won't include any of the hierarchical grouping code. Note: For now both branches call the current version of_save_aggregate, as the new version has yet to be written.In addition, two bits of logic from
save_error_events, which set group data on the event and the job, have been moved into the new wrapper.