fix(feedback): Get feedback integration using getIntegrationByName#64581
Merged
Conversation
Gets the feedback integration via the newer `feedbackIntegration` function as described in the deprecation notice. Currently the button does not show up because feedback is undefined
github-actions
Bot
added
the
Scope: Frontend
billyvg
approved these changes
Feb 5, 2024
billyvg
reviewed
Feb 5, 2024
| const config = useLegacyStore(ConfigStore); | ||
| const hub = getCurrentHub(); | ||
| const feedback = hub.getIntegration(Feedback); | ||
| const feedback = feedbackIntegration(); |
Member
There was a problem hiding this comment.
Oh wait, I think we want to get the feedback integration instance from the SDK
Member
There was a problem hiding this comment.
e.g. getClient().getIntegrationByName('Feedback')
Member
Author
|
This PR seems to be unnecessary, i just didn't understand it was only defined in getsentry |
scttcper
changed the title
feedbackIntegrationgetIntegrationByName
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets the feedback integration via the newer function as described in the deprecation notice