ref(typing): type group_event_details#65309
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
JoshFerge
commented
Feb 16, 2024
|
|
||
| def issue_search_query_to_conditions( | ||
| query: str, group: Group, user: User, environments: Sequence[Environment] | ||
| query: str, group: Group, user: User | AnonymousUser, environments: Sequence[Environment] |
Member
Author
There was a problem hiding this comment.
in practice i don't think an AnonymousUser would ever make it in here, as to access the endpoint the user would have to be authed, although I don't think we have a way of defining the user type based on the type of request atm.
Member
Author
There was a problem hiding this comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #65309 +/- ##
==========================================
- Coverage 81.47% 81.46% -0.01%
==========================================
Files 5255 5255
Lines 232112 232115 +3
Branches 45524 45524
==========================================
- Hits 189106 189101 -5
- Misses 37127 37132 +5
- Partials 5879 5882 +3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.