Skip to content

ref(typing): add typings for tsdb/redis#65785

Merged
anonrig merged 1 commit intomasterfrom
anonrig/add-type-tsdb-redis
Feb 27, 2024
Merged

ref(typing): add typings for tsdb/redis#65785
anonrig merged 1 commit intomasterfrom
anonrig/add-type-tsdb-redis

Conversation

@anonrig
Copy link
Copy Markdown
Contributor

@anonrig anonrig commented Feb 26, 2024

Adds the remaining types for TSDB base and redis implementations

@anonrig anonrig requested review from a team, JoshFerge and asottile-sentry February 26, 2024 16:41
@anonrig anonrig requested a review from a team as a code owner February 26, 2024 16:41
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 26, 2024
@anonrig anonrig force-pushed the anonrig/add-type-tsdb-redis branch from 6f9f4bb to bb511c9 Compare February 26, 2024 16:55
Copy link
Copy Markdown
Contributor

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 98.25581% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.21%. Comparing base (85d0fa7) to head (c6c0b42).
Report is 71 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #65785      +/-   ##
==========================================
+ Coverage   84.10%   84.21%   +0.10%     
==========================================
  Files        5272     5276       +4     
  Lines      235833   236055     +222     
  Branches    40839    40869      +30     
==========================================
+ Hits       198347   198783     +436     
+ Misses      37267    37053     -214     
  Partials      219      219              
Files Coverage Δ
src/sentry/tsdb/redis.py 95.09% <100.00%> (+0.09%) ⬆️
src/sentry/tsdb/snuba.py 89.13% <ø> (ø)
src/sentry/tsdb/base.py 96.00% <92.30%> (-1.55%) ⬇️

... and 82 files with indirect coverage changes

Copy link
Copy Markdown
Contributor

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anonrig anonrig force-pushed the anonrig/add-type-tsdb-redis branch from d26d391 to c6c0b42 Compare February 27, 2024 17:21
@anonrig anonrig merged commit b84f38f into master Feb 27, 2024
@anonrig anonrig deleted the anonrig/add-type-tsdb-redis branch February 27, 2024 18:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants