Skip to content

ref(typing): fix all strong types#65902

Merged
anonrig merged 1 commit intomasterfrom
anonrig/fix-strong-type-errors
Feb 27, 2024
Merged

ref(typing): fix all strong types#65902
anonrig merged 1 commit intomasterfrom
anonrig/fix-strong-type-errors

Conversation

@anonrig
Copy link
Copy Markdown
Contributor

@anonrig anonrig commented Feb 27, 2024

The definitions for stronger types are wrong. It should not start with src. prefix.

Pinging @armenzg for visibility

cc @getsentry/python-typing

@anonrig anonrig requested review from a team and asottile-sentry February 27, 2024 18:53
@anonrig anonrig requested review from a team as code owners February 27, 2024 18:53
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 27, 2024
@anonrig anonrig force-pushed the anonrig/fix-strong-type-errors branch from 4e24ccb to 4c137f5 Compare February 27, 2024 19:09
Copy link
Copy Markdown
Contributor

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anonrig anonrig enabled auto-merge (squash) February 27, 2024 19:13
@anonrig anonrig merged commit 03e5fc1 into master Feb 27, 2024
@anonrig anonrig deleted the anonrig/fix-strong-type-errors branch February 27, 2024 19:38
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants