Skip to content

ref(feedback): close sidebar upon page refresh#65934

Closed
michellewzhang wants to merge 1 commit into
masterfrom
mz/close-panel
Closed

ref(feedback): close sidebar upon page refresh#65934
michellewzhang wants to merge 1 commit into
masterfrom
mz/close-panel

Conversation

@michellewzhang

Copy link
Copy Markdown
Contributor
  • Close the sidebar when user refreshes the page
  • Don't render the verify step or next steps (we don't need it)
Screen.Recording.2024-02-27.at.2.36.34.PM.mov

@michellewzhang michellewzhang requested a review from a team as a code owner February 27, 2024 22:37
@michellewzhang michellewzhang requested a review from a team February 27, 2024 22:37
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 27, 2024
trackAnalytics('feedback.index-setup-viewed', {
organization,
});
SidebarPanelStore.hidePanel('feedback-sidequest');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what hides the panel upon page refresh

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sidebar being active/hidden is controlled by thisSidebarPanelStore

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yeah i see it.

@michellewzhang michellewzhang deleted the mz/close-panel branch February 29, 2024 19:15
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants