feat(auditlog): Add Trial and Plan Events to Audit Log#6671
Merged
Conversation
tkaemming
previously requested changes
Dec 4, 2017
Contributor
There was a problem hiding this comment.
Blocking this until GH-6617 is merged.
If we continue this pattern we should reevaluate, though.
– @tkaemming, Dec 1, 2017, 3:10 PM PST
tkaemming
approved these changes
Jan 25, 2018
| elif self.event == AuditLogEntryEvent.TRIAL_STARTED: | ||
| return 'started trial' | ||
| elif self.event == AuditLogEntryEvent.PLAN_CHANGED: | ||
| return 'changed plan to %s' % (self.data['plan_name'], ) |
Contributor
There was a problem hiding this comment.
Didn't validate this is actually part of the data payload
Contributor
Author
|
Ok, I'm going to try and open the |
Contributor
|
Sounds like a plan 👌 |
Contributor
Author
|
Rez'ing 💀 |
Adding trial and plan event types for audit log entries so hosted Sentry can include these in customer audit logs. See #6617
ehfeng
force-pushed
the
plan-audit-log
branch
2 times, most recently
from
f6eb84e to
f7b4410
Compare
Contributor
Author
|
Ignoring code coverage because the tests would be within our other repo. Would need to use the manager pattern to fix this. |
egsy
pushed a commit
that referenced
this pull request
May 5, 2018
* feat(auditlog): Add Trial and Plan Events to Audit Log Adding trial and plan event types for audit log entries so hosted Sentry can include these in customer audit logs. See #6617 * incrementing for meredith's branch * removing merge artifact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding trial and plan event types for audit log entries so hosted Sentry can include these in customer audit logs.
See #6617