chore: Added Unity Metrics onboarding#67064
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
ArthurKnaus
approved these changes
Mar 18, 2024
| EnableCodeLocations = true | ||
| }; | ||
| }`; | ||
| export const getUnityMetricsOnboarding = (): OnboardingConfig => ({ |
Member
There was a problem hiding this comment.
Nit: as this is used in only one platform I would hardcode it directly in unity.tsx 🤷
Contributor
There was a problem hiding this comment.
would be nice to apply more abstractions to all the platforms, but let's ,merge for now to unblock the users, and follow up on that later
Member
There was a problem hiding this comment.
More abstraction potentially makes it harder to change the content and also makes us less flexible. Would be very careful with adding it here. We have to edit the docs content quite often. 🤔
But lets follow up on that 👍
Contributor
|
@bitsandfoxes and issue to merge 🚀 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added onboarding for the frontend platform
Unity.