ref(perf): Accept MutableQuery in data loading hooks#67080
Merged
Conversation
Set `enabled` to the simplest expression that mimics the existing behaviour.
Replace the `filters` param of `useSpanMetrics` and `useSpanMetricsSeries` with a `search` param that accepts a `MutableQuery`.
github-actions
bot
added
the
Scope: Frontend
AbhiPrasad
approved these changes
Mar 18, 2024
Contributor
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
I like being opinionated with only allowing MutableSearch to be passed in especially because we don't have to worry about backwards compat here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hooks like
useSpanMetricsanduseSpanMetricsSerieswere written early in Starfish, for simple use cases. Thefiltersobject is a simple key-value of fields and the values we want. This served us well when we were iterating quickly, but it's not a good choice anymore.MutableSearcheverywhere else. It's not consistent to have a different API here, and using an object doesn't provide a clear win now thatMutableSearch.fromQueryObjectexists and makes it easy to create simple filtersThis PR updates the data loading hooks to accept a
MutableSearchinstead.I think it also would have been fine to have accept either
filtersorMutableSearchbut I didn't like that, it's just more thinking IMO, but you tell me.