Skip to content

fix(contexts): Coerce large nested number values in context to strings#67488

Merged
jangjodi merged 3 commits into
masterfrom
jodi/nested-large-nums-context
Apr 4, 2024
Merged

fix(contexts): Coerce large nested number values in context to strings#67488
jangjodi merged 3 commits into
masterfrom
jodi/nested-large-nums-context

Conversation

@jangjodi

Copy link
Copy Markdown
Contributor

Coerce large nested numbers into strings so that they aren't rounded
See #66877 for more context of the original problem

Fixes #66692

@jangjodi jangjodi requested review from a team as code owners March 21, 2024 22:37
@jangjodi jangjodi requested a review from leeandher March 21, 2024 22:37
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 21, 2024
@codecov

codecov Bot commented Mar 21, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.36%. Comparing base (008ca57) to head (add800e).
Report is 2 commits behind head on master.

❗ Current head add800e differs from pull request most recent head bec019c. Consider uploading reports for the commit bec019c to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #67488       +/-   ##
===========================================
+ Coverage   53.53%   79.36%   +25.82%     
===========================================
  Files        5403     6370      +967     
  Lines      227066   282241    +55175     
  Branches    39083    48570     +9487     
===========================================
+ Hits       121556   223989   +102433     
+ Misses     105158    57812    -47346     
- Partials      352      440       +88     
Files Coverage Δ
src/sentry/interfaces/contexts.py 98.54% <100.00%> (+38.07%) ⬆️

... and 2715 files with indirect coverage changes

@leeandher leeandher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@jangjodi jangjodi merged commit 60f1f84 into master Apr 4, 2024
@jangjodi jangjodi deleted the jodi/nested-large-nums-context branch April 4, 2024 17:17
shellmayr pushed a commit that referenced this pull request Apr 10, 2024
#67488)

Coerce large nested numbers into strings so that they aren't rounded
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect data in events when adding large integers to context data

2 participants