Skip to content

ref: upgrade djangorestframework#67597

Merged
asottile-sentry merged 1 commit into
masterfrom
asottile-upgrade-drf
Mar 28, 2024
Merged

ref: upgrade djangorestframework#67597
asottile-sentry merged 1 commit into
masterfrom
asottile-upgrade-drf

Conversation

@asottile-sentry

@asottile-sentry asottile-sentry commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

this finally gets us off of pytz \o/

nothing looked that scary in the changelog but will watch this one pretty closely

@asottile-sentry asottile-sentry requested a review from a team March 25, 2024 14:48
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 25, 2024
@asottile-sentry asottile-sentry marked this pull request as ready for review March 25, 2024 15:29
@asottile-sentry asottile-sentry requested a review from a team as a code owner March 25, 2024 15:29
@asottile-sentry asottile-sentry requested a review from a team March 25, 2024 16:11

@wedamija wedamija left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to bake this in s4s for a while?

@asottile-sentry

Copy link
Copy Markdown
Contributor Author

Does it make sense to bake this in s4s for a while?

s4s doesn't get much api traffic so I doubt it will help beyond the normal bake period. our acceptance suite gives better coverage than s4s here I think

@wedamija

Copy link
Copy Markdown
Member

Does it make sense to bake this in s4s for a while?

s4s doesn't get much api traffic so I doubt it will help beyond the normal bake period. our acceptance suite gives better coverage than s4s here I think

Fair point 👍

this finally gets us off of pytz \o/
@asottile-sentry asottile-sentry merged commit 08c9f1e into master Mar 28, 2024
@asottile-sentry asottile-sentry deleted the asottile-upgrade-drf branch March 28, 2024 13:26
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants